Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34754 )
Change subject: soc/intel/cannonlake: Add provision to skip postcar and load ramstage ......................................................................
Patch Set 11:
Patch Set 10:
Patch Set 10: Code-Review+1
My guess is that we'd need to combine this logic into some other location so we don't duplicate the if/else all over the code base.
we can do the same inside postcar_loader.c run_postcar_phase() and check like below ?
void run_postcar_phase(struct postcar_frame *pcf) { struct prog prog = PROG_INIT(PROG_POSTCAR, CONFIG_CBFS_PREFIX "/postcar");
if (CONFIG(RAMSTAGE_LOADS_FROM_RAMSTAGE)) { run_ramstage_phase(&pcf); /* control shouldn't come here */ } run_phase(pcf, prog, STAGE_POSTCAR, CBMEM_ID_AFTER_CAR);
}
That would work.