Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48520 )
Change subject: src/lib: Add Kconfig option for SPD cache in FMAP ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48520/1/src/lib/Kconfig File src/lib/Kconfig:
https://review.coreboot.org/c/coreboot/+/48520/1/src/lib/Kconfig@57 PS1, Line 57: _IN_FMAP
Do we need the _IN_FMAP part? Also, should SODIMM be in the name? SODIMM_SPD_CACHE?
I'm not sure how else one might cache SPD data, but felt like being more explicit was better than less. I have no problem changing if another symbol is preferred
https://review.coreboot.org/c/coreboot/+/48520/1/src/lib/Kconfig@62 PS1, Line 62: board-level implementation
I think this should be something that a common library or SoC code handles. […]
I'll ponder how to do that for a follow up :)
https://review.coreboot.org/c/coreboot/+/48520/1/src/lib/Kconfig@64 PS1, Line 64: RW_SPD_CACHE
Just a note: Since the default is being set to RW_SPD_CACHE, any board using this in their own custo […]
this is actually hardcoded in spd_cache.h; I tried finding a way to make it a Kconfig symbol so it could be set dynamically, but came up empty due to the limitations of Makefiles (I believe SMMSTORE is handled similarly for the same reason).