Paul Menzel (paulepanter@users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6673
-gerrit
commit 1b6f7c679aec6531de238f651c58850ca3dc745f Author: Paul Menzel paulepanter@users.sourceforge.net Date: Fri Aug 15 10:32:50 2014 +0200
lenovo/x60/i915.c: Define `BSM` to fix build error
Commit 8aeab56b (lenovo/x60/i915.c: Use define for `BSM`) [1] breaks the build of the Lenovo X60 with native graphics initialization [2].
CC mainboard/lenovo/x60/i915.ramstage.o src/mainboard/lenovo/x60/i915.c: In function ‘gtt_setup’: src/mainboard/lenovo/x60/i915.c:141:69: error: ‘BSM’ undeclared (first use in this function) src/mainboard/lenovo/x60/i915.c:141:69: note: each undeclared identifier is reported only once for each function it appears in
To fix the error, add the define for `BSM` in the file directly as including the header `src/northbridge/intel/i945/i945.h` does not work.
[1] http://review.coreboot.org/5932 [2] This was not caught as only the commit on top was build tested, which removes that line where `BSM` is used.
Change-Id: Ic24c66b0175a67ad95064a9840daa615ab88c1ee Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net --- src/mainboard/lenovo/x60/i915.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/src/mainboard/lenovo/x60/i915.c b/src/mainboard/lenovo/x60/i915.c index 8fbd2a1..529b262 100644 --- a/src/mainboard/lenovo/x60/i915.c +++ b/src/mainboard/lenovo/x60/i915.c @@ -48,6 +48,7 @@ enum { vmsg = 1, vio = 2, vspin = 4, };
+#define BSM 0x5c #define PGETLB_CTL 0x2020
static int verbose = 0;