[coreboot-gerrit] [S] Change in coreboot[master]: soc/amd/common/iommu.c: Make sure iommu is enabled

[Felix Held (Code Review)]

Attention is currently required from: Arthur Heymans, Eric Lai, Jason Glenesk, Matt DeVillier, Naresh Solanki, Raul Rangel.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75829?usp=email )

Change subject: soc/amd/common/iommu.c: Make sure iommu is enabled
......................................................................

Patch Set 6:

(1 comment)

File src/soc/amd/common/block/iommu/iommu.c:

https://review.coreboot.org/c/coreboot/+/75829/comment/d795a2da_25a897c8 :
PS3, Line 21: 	res->flags = IORESOURCE_MEM;
> > probably something for a separate patch, but shouldn't we add IORESOURCE_PCI64 here too, so that t […]

the limit should stay the same, but when selecting IORESOURCE_PCI64, the IOMMU_CAP_BASE_HI  register will be written too; right now that register doesn't get written. since the reset value is 0, this isn't necessarily a problem though