HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41332 )
Change subject: src/soc/rockchip: Remove direct 'include <soc/gpio.h>' ......................................................................
src/soc/rockchip: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: Ib7e71007cd111083eb6c7deda9def5d223c01f1f Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/rockchip/common/gpio.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3288/gpio.c M src/soc/rockchip/rk3399/display.c M src/soc/rockchip/rk3399/gpio.c 5 files changed, 0 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/41332/1
diff --git a/src/soc/rockchip/common/gpio.c b/src/soc/rockchip/common/gpio.c index 73ddfd7..5629e6b 100644 --- a/src/soc/rockchip/common/gpio.c +++ b/src/soc/rockchip/common/gpio.c @@ -3,7 +3,6 @@ #include <device/mmio.h> #include <assert.h> #include <gpio.h> -#include <soc/gpio.h> #include <soc/grf.h> #include <soc/soc.h> #include <types.h> diff --git a/src/soc/rockchip/rk3288/display.c b/src/soc/rockchip/rk3288/display.c index fd86b95..f5f5d7c 100644 --- a/src/soc/rockchip/rk3288/display.c +++ b/src/soc/rockchip/rk3288/display.c @@ -13,7 +13,6 @@ #include <soc/display.h> #include <soc/edp.h> #include <soc/hdmi.h> -#include <soc/gpio.h> #include <soc/grf.h> #include <soc/soc.h> #include <soc/vop.h> diff --git a/src/soc/rockchip/rk3288/gpio.c b/src/soc/rockchip/rk3288/gpio.c index 885b419..ad1972b 100644 --- a/src/soc/rockchip/rk3288/gpio.c +++ b/src/soc/rockchip/rk3288/gpio.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <gpio.h> -#include <soc/gpio.h> #include <soc/grf.h> #include <soc/pmu.h> #include <soc/soc.h> diff --git a/src/soc/rockchip/rk3399/display.c b/src/soc/rockchip/rk3399/display.c index b47fabc..eca0588 100644 --- a/src/soc/rockchip/rk3399/display.c +++ b/src/soc/rockchip/rk3399/display.c @@ -12,7 +12,6 @@ #include <soc/clock.h> #include <soc/display.h> #include <soc/edp.h> -#include <soc/gpio.h> #include <soc/grf.h> #include <soc/mmu_operations.h> #include <soc/mipi.h> diff --git a/src/soc/rockchip/rk3399/gpio.c b/src/soc/rockchip/rk3399/gpio.c index 6c022d8..8c66987 100644 --- a/src/soc/rockchip/rk3399/gpio.c +++ b/src/soc/rockchip/rk3399/gpio.c @@ -2,7 +2,6 @@
#include <gpio.h> #include <soc/addressmap.h> -#include <soc/gpio.h> #include <soc/grf.h> #include <soc/soc.h>