1 Jun
2022
1 Jun
'22
5:28 p.m.
Attention is currently required from: Bora Guvendik, Anil Kumar K, Cliff Huang. Jeremy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63945 )
Change subject: mb/intel/adlrvp: x4 slot support (SD card support) for Adl-P RVP ......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/intel/adlrvp/gpio.c:
https://review.coreboot.org/c/coreboot/+/63945/comment/d24d1c25_db4423fe PS6, Line 189: // PAD_CFG_NF(GPP_A7, NONE, DEEP, NF1), you should remove this line altogether if unnecessary instead of commenting it out.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63945
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba5d83d133b6ae8cd389ddd971db308170094300
Gerrit-Change-Number: 63945
Gerrit-PatchSet: 6
Gerrit-Owner: Cliff Huang cliff.huang@intel.com
Gerrit-Reviewer: Anil Kumar K anil.kumar.k@intel.corp-partner.google.com
Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anil Kumar K anil.kumar.k@intel.com
Gerrit-CC: Cliff Huang cliff.huang@intel.corp-partner.google.com
Gerrit-CC: Jeremy Compostella jeremy.compostella@intel.corp-partner.google.com
Gerrit-Attention: Bora Guvendik bora.guvendik@intel.com
Gerrit-Attention: Anil Kumar K anil.kumar.k@intel.com
Gerrit-Attention: Cliff Huang cliff.huang@intel.com
Gerrit-Attention: Anil Kumar K anil.kumar.k@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Jun 2022 17:28:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment