Attention is currently required from: Andrey Petrov, Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Matt DeVillier, Ronak Kanabar, Sean Rhodes.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81618?usp=email )
Change subject: lib: Refactor bmp_load_logo() implementation
......................................................................
Patch Set 2:
(2 comments)
File src/lib/bmp_logo.c:
https://review.coreboot.org/c/coreboot/+/81618/comment/4b386411_e17ec758 :
PS1, Line 19: void bmp_load_logo(uintptr_t *logo_ptr, size_t *logo_size)
Why does this function take two out-pointers and have no return value, anyway? I think that's a very […]
Acknowledged
File src/soc/amd/mendocino/fsp_s_params.c:
https://review.coreboot.org/c/coreboot/+/81618/comment/1e6f1be4_eef610b5 :
PS1, Line 59: (uintptr_t *)
You can't do these kinds of things. […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81618?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I14bc54670a67980ec93bc366b274832d1f959e50
Gerrit-Change-Number: 81618
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 02 Apr 2024 09:42:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment