HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33934 )
Change subject: lib: Rewrite qemu-armv7 ramdetect ......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/33934/5/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-armv7/cbmem.c:
https://review.coreboot.org/c/coreboot/+/33934/5/src/mainboard/emulation/qem... PS5, Line 20: return _dram + : (probe_ramsize((uintptr_t)_dram, CONFIG_DRAM_SIZE_MB) * MiB); length less than 96 I think. one line ?
https://review.coreboot.org/c/coreboot/+/33934/5/src/soc/ucb/riscv/cbmem.c File src/soc/ucb/riscv/cbmem.c:
https://review.coreboot.org/c/coreboot/+/33934/5/src/soc/ucb/riscv/cbmem.c@2... PS5, Line 20: return _dram + : (probe_ramsize((uintptr_t)_dram, CONFIG_DRAM_SIZE_MB) * MiB); one line?