Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74616 )
Change subject: cpu/amd/pi/00730F01/fixme: use coreboot's PCI access functions ......................................................................
Patch Set 1:
(1 comment)
File src/cpu/amd/pi/00730F01/fixme.c:
https://review.coreboot.org/c/coreboot/+/74616/comment/dd4ea410_03f816e7 PS1, Line 19: 0x00fedf00
Nevermind, it looks like we're good.
no, that magic constant is what gets written to the register. address bits 0..15 aren't taken into account here and the lower 8 bits in the register aren't address bits, but some control bits. this patch only changed the regster accesses, but preserved the magic constants (although making them use lower-case chars). the next one will get rid of some of the magic constants; the replacements were inspired by the stoneyridge code