Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35001 )
Change subject: mb/google/kukui: Add panel for Kodama
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35001/5/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/panel_params/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35001/5/src/mainboard/google/kukui/...
PS5, Line 2: panel-params-$(CONFIG_BOARD_GOOGLE_KODAMA) += panel-AUO_B101UAN08_3
sorry, we should still sort by $(CONFIG_*) first here, otherwise it'll be pretty hard to manage...
please put this in
panel-...KRANE += ... AUO
panel-...KRANE += ... BOE
panel-...KODAMA += ... AUO
panel-...KODAMA += ... BOE
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35001
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f688ffd0ece6afac08d353ab5a6cf1cf876b32f
Gerrit-Change-Number: 35001
Gerrit-PatchSet: 5
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 21 Aug 2019 23:38:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
