Sergii Dmytruk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83422?usp=email )
Change subject: drivers/efi/uefi_capsules.c: coalesce and store UEFI capsules ......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Nice work. Please paste the new log lines in here for the record.
Here's the log after posting a capsule: ``` ... [INFO ] capsules: capsule block #0 at 0x7f52fa18. [SPEW ] EFIVARS: UEFI FV with size 262144 found [SPEW ] EFIVARS: UEFI variable store with size 65464 found [SPEW ] Found variable with state 3f and GUID: d9bee56e-75dc-49d9-b4d7b534210f637a ... [INFO ] capsules: processing 1 capsule block(s). [SPEW ] capsules: mapping 0x00000008 bytes at 0x7f52fa18. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x00000008 bytes at 0x7f52fa20. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x0000001c bytes at 0x7d35b018. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x00000008 bytes at 0x7f52fa28. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x00000008 bytes at 0x7f52fa30. [SPEW ] capsules: no need to map anything. [DEBUG] capsules: chained capsule blocks. [SPEW ] capsules: mapping 0x00000008 bytes at 0x7f52fa18. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x00000008 bytes at 0x7f52fa20. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x00000008 bytes at 0x7f52fa28. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x00000008 bytes at 0x7f52fa30. [SPEW ] capsules: no need to map anything. [DEBUG] capsules: reserved capsule blocks. [DEBUG] capsules: coalescing capsules data @ 0x7ed15000. [SPEW ] capsules: mapping 0x00000008 bytes at 0x7f52fa18. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x00000008 bytes at 0x7f52fa20. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x0000001c bytes at 0x7d35b018. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x00200000 bytes at 0x7d35b018. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x00200000 bytes at 0x7d55b018. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x00200000 bytes at 0x7d75b018. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x00200000 bytes at 0x7d95b018. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x00019dfb bytes at 0x7db5b018. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x00000008 bytes at 0x7f52fa28. [SPEW ] capsules: no need to map anything. [SPEW ] capsules: mapping 0x00000008 bytes at 0x7f52fa30. [SPEW ] capsules: no need to map anything. [INFO ] capsules: found 1 capsule(s). [DEBUG] BS: BS_DEV_INIT exit times (exec / console): 1 / 36 ms [INFO ] Enabled capsule update SMI handler [INFO ] Finalize devices... [INFO ] Devices finalized ... [DEBUG] Writing coreboot table at 0x7fd66000 [INFO ] capsules: reserving capsules data @ 0x7ed15000. [DEBUG] 0. 0000000000000000-0000000000000fff: CONFIGURATION TABLES [DEBUG] 1. 0000000000001000-000000000009ffff: RAM [DEBUG] 2. 00000000000a0000-00000000000fffff: RESERVED [DEBUG] 3. 0000000000100000-000000007ed14fff: RAM [DEBUG] 4. 000000007ed15000-000000007f52efff: RESERVED [DEBUG] 5. 000000007f52f000-000000007fd25fff: RAM [DEBUG] 6. 000000007fd26000-000000007fd7efff: CONFIGURATION TABLES [DEBUG] 7. 000000007fd7f000-000000007feccfff: RAMSTAGE [DEBUG] 8. 000000007fecd000-000000007fefffff: CONFIGURATION TABLES [DEBUG] 9. 000000007ff00000-000000007fffffff: RESERVED [DEBUG] 10. 00000000b0000000-00000000bfffffff: RESERVED [DEBUG] 11. 0000000100000000-000000017fffffff: RAM [INFO ] capsules: publishing a capsule @ 0x7ed15000. ... ```