[coreboot-gerrit] Change in coreboot[master]: mb/google/drallion/variants/drallion: Update thermal configuration fo...

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36860 )

Change subject: mb/google/drallion/variants/drallion: Update thermal configuration for DPTF
......................................................................

Patch Set 3: Code-Review+2

(4 comments)

https://review.coreboot.org/c/coreboot/+/36860/1/src/mainboard/google/dralli... 
File src/mainboard/google/drallion/variants/drallion/include/variant/acpi/dptf.asl:

https://review.coreboot.org/c/coreboot/+/36860/1/src/mainboard/google/dralli... 
PS1, Line 17: 127
> From b/144464314#8 […]

Ack

https://review.coreboot.org/c/coreboot/+/36860/1/src/mainboard/google/dralli... 
PS1, Line 60: 15
> Our project TDP is 15W, the reason is DPTF just use passive policy 1, so we set PL1 Max=TDP, […]

Ack

https://review.coreboot.org/c/coreboot/+/36860/1/src/mainboard/google/dralli... 
PS1, Line 62: 10
> There is no issue about this change, BTW is there any setting you recommendation about this value?

Ack

https://review.coreboot.org/c/coreboot/+/36860/1/src/mainboard/google/dralli... 
PS1, Line 67: 4
> Which one do you confused? PL1 min or PL2 min? there will have a change that we will revise PL2 min  […]

Ack