[coreboot-gerrit] Change in coreboot[master]: security/intel/stm: Add STM support

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33234 )

Change subject: security/intel/stm: Add STM support
......................................................................

Patch Set 48:

(1 comment)
> Patch Set 48: Code-Review+1
> > Patch Set 48:
> >
> > I assume the -1 is because we don't test builds with STM enabled. I thought we only test builds with default configs (that used to be true, and why it is why bayou bit-rotted for years and we had to just remove it).
> >
> > If someone can correct my misunderstanding, let me know, else my +2 stands.
>
> so I'm hopelessly out of touch. I'll as Eugene for a test build config.

I would also like a boot-test to be sure code doesn't break. For the build test config, just place a defconfig file in configs/ that selects STM

https://review.coreboot.org/c/coreboot/+/33234/48/src/security/intel/stm/Stm... 
File src/security/intel/stm/StmPlatformSmm.c:

https://review.coreboot.org/c/coreboot/+/33234/48/src/security/intel/stm/Stm... 
PS48, Line 153: FXSAVE_SIZE
That is defined in src/cpu/x86/smm/smm_module_loader.c already, maybe the define should be moved into a header?

In any case, this can be done later.