Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47308 )
Change subject: mb/google/zork: Init fingerprint GPIOs for boot vs resume
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47308/4/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47308/4/src/mainboard/google/zork/v...
PS4, Line 317: slp_typ != ACPI_S0
In my testing, I either got an S3 or an S0 wake. […]
If you poweroff and power back on within 10 seconds, I think it should be waking up from S5. Does that not happen?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47308
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16a2e621145782e0a908bb3e49478586c09a0e0a
Gerrit-Change-Number: 47308
Gerrit-PatchSet: 4
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Peichao Wang
pwang12@lenovo.corp-partner.google.com
Gerrit-Comment-Date: Mon, 09 Nov 2020 21:26:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment