[coreboot-gerrit] Change in coreboot[master]: src/acpi/acpigen_usb.c: Fix False Memory leak error

[Angel Pons (Code Review)]

Attention is currently required from: Felix Singer, Nico Huber, Tim Wawrzynczak, Paul Menzel, vaibhav.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62968 )

Change subject: src/acpi/acpigen_usb.c: Fix False Memory leak error
......................................................................

Patch Set 2:

(1 comment)

File src/acpi/acpigen_usb.c:

https://review.coreboot.org/c/coreboot/+/62968/comment/400603fb_a8dc1e19 
PS2, Line 92: #ifdef __clang_analyzer__
            : 	free(fresh);
            : 	#endif
> Hmm, right now we do not have any instances of this in the code I can found, other than vendorcode,  […]

I think scan-build is just stupid. The `acpi_dp_add_reference()` function stores a copy of the pointer, so it does not leak *here*. Strictly speaking, the memory actually leaks if the pointer doesn't get freed once the acpi_dp_* stuff no longer needs it.

I guess one way to handle this could be to move the `strdup()` call inside the acpi_dp_* functions, and free all the pointers after they're no longer needed.