Ravishankar Sarawadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44748 )
Change subject: mb/volteer: Remove DQ mappings for LPDDR4 ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/44748/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44748/4//COMMIT_MSG@7 PS4, Line 7: DQ/DQS
Should be remove DQ. […]
Done
https://review.coreboot.org/c/coreboot/+/44748/4//COMMIT_MSG@9 PS4, Line 9: MRC v0.7.0
Current fsp 3312 (landed before) can support this feature. […]
Ack
https://review.coreboot.org/c/coreboot/+/44748/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/memory.c:
https://review.coreboot.org/c/coreboot/+/44748/4/src/mainboard/google/voltee... PS4, Line 9: dqs_map
Hi Furquan, […]
Ack
https://review.coreboot.org/c/coreboot/+/44748/4/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/meminit.h:
https://review.coreboot.org/c/coreboot/+/44748/4/src/soc/intel/tigerlake/inc... PS4, Line 89: dqs_map
This needs to be dropped as well as per commit message.
Only DQ needs to be removed, commit msg updated.
https://review.coreboot.org/c/coreboot/+/44748/4/src/soc/intel/tigerlake/mem... File src/soc/intel/tigerlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/44748/4/src/soc/intel/tigerlake/mem... PS4, Line 392:
This is not correct. You are dropping the mappings for DDR4.
I will remove this and keep it for LP4 only.