[coreboot-gerrit] Change in coreboot[master]: acpi: add a function to read a table and verify it

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41388 )

Change subject: acpi: add a function to read a table and verify it
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41388/2/src/acpi/acpi.c 
File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/41388/2/src/acpi/acpi.c@268 
PS2, Line 268: 	file = acpi_read_table(CONFIG_CBFS_PREFIX "/madt.aml", "APIC");
> which one? I mean which Kconfig?  […]

I didn't know we were doing that for dsdt and slic. Seems completely unnecessary when one knows we're not taking that path. SLIC is not always used. It's unfortunate we're unconditionally trying that. dsdt, granted, is inherently packaged in cbfs by the nature of how we build.

I'd prefer we don't try slic and madt unless instructed. Likewise, we shouldn't be using cbfs_boot_map_with_leak() as it makes quite a few assumptions about the boot media.