View Change
1 comment:
File src/acpi/acpi.c:
Patch Set #2, Line 268: file = acpi_read_table(CONFIG_CBFS_PREFIX "/madt.aml", "APIC");
which one? I mean which Kconfig? […]
I didn't know we were doing that for dsdt and slic. Seems completely unnecessary when one knows we're not taking that path. SLIC is not always used. It's unfortunate we're unconditionally trying that. dsdt, granted, is inherently packaged in cbfs by the nature of how we build.
I'd prefer we don't try slic and madt unless instructed. Likewise, we shouldn't be using cbfs_boot_map_with_leak() as it makes quite a few assumptions about the boot media.
To view, visit change 41388. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5e82eb0a82555b7763107e2a1e2a529a0c1b11f
Gerrit-Change-Number: 41388
Gerrit-PatchSet: 3
Gerrit-Owner: ron minnich <rminnich@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-Comment-Date: Thu, 14 May 2020 02:57:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin <adurbin@chromium.org>
Comment-In-Reply-To: ron minnich <rminnich@gmail.com>
Gerrit-MessageType: comment