[coreboot-gerrit] [M] Change in coreboot[main]: vc/google/chromeos: Implement platform callback for critical shutdown

[Julius Werner (Code Review)]

Attention is currently required from: Karthik Ramasubramanian, Subrata Banik.

Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86228?usp=email )

Change subject: vc/google/chromeos: Implement platform callback for critical shutdown
......................................................................

Patch Set 4:

(2 comments)

File src/vendorcode/google/chromeos/battery.c:

https://review.coreboot.org/c/coreboot/+/86228/comment/1ec200c6_a456aed9?usp... :
PS4, Line 35: 			checked = true;
No, this needs to be outside the inner `if`. Even if the result was false (= no need to shut down), we want to make sure we cache that result and don't query it again later.

https://review.coreboot.org/c/coreboot/+/86228/comment/69aeecd3_67f70251?usp... :
PS4, Line 50:  * 3. If in romstage and Chrome EC is supported, sends a shutdown command to the EC.
Why the romstage/ramstage difference? You're saying what the code does but you're not explaining _why_ it does things that way, which is really the most important part.