Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36358 )
Change subject: arch/x86/cbmem.c: Clean up unused paths
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36358/1/src/arch/x86/cbmem.c
File src/arch/x86/cbmem.c:
https://review.coreboot.org/c/coreboot/+/36358/1/src/arch/x86/cbmem.c@22
PS1, Line 22: return (void *)restore_top_of_low_cacheable();
Assume this to be slow. It would be nice if the callee (cbmem_top()) would cache the value in romstage, even though we did not previously do it.
MAYBE_STATIC_BSS should cover the NO_CAR_GLOBAL_MIGRATION use case?
done in CB:36144
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36358
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I023f11cfcefacdcae3c5db22bf98b40a3575cc9c
Gerrit-Change-Number: 36358
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 26 Oct 2019 15:36:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment