Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44039 )
Change subject: mb/google/volteer: Use device aliases ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44039/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/lindar/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44039/5/src/mainboard/google/voltee... PS5, Line 22: device pci 07.0 off end # TBT_PCIe0 0x9A23 : device pci 07.1 off end # TBT_PCIe1 0x9A25 Don't we still need these as baseboard devicetree is enabling them? Also the tbt_dma0?
https://review.coreboot.org/c/coreboot/+/44039/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44039/5/src/mainboard/google/voltee... PS5, Line 29: device pci 07.0 off end # TBT_PCIe0 0x9A23 : device pci 07.1 off end # TBT_PCIe1 0x9A25 Same here.
https://review.coreboot.org/c/coreboot/+/44039/5/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chipset.cb:
PS5: Bad rebase?