Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47599 )
Change subject: arch/x86: Top align bootblock program ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Looks good.
https://review.coreboot.org/c/coreboot/+/47599/1/src/arch/x86/bootblock_crt0... File src/arch/x86/bootblock_crt0.S:
https://review.coreboot.org/c/coreboot/+/47599/1/src/arch/x86/bootblock_crt0... PS1, Line 19: #include <cpu/x86/16bit/entry16.inc> : #include <cpu/x86/16bit/reset16.inc> : #include <cpu/x86/32bit/entry32.inc> So this is the only thing that really needs to be in the init section. All the rest is just to be more efficient if SIPI is in ROM (to fill up the top 4K)?
https://review.coreboot.org/c/coreboot/+/47599/1/src/arch/x86/bootblock_crt0... PS1, Line 57: .previous So directive swaps this to the previous section? What does this mean here?