Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Aaron Durbin.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54302 )
Change subject: Kconfig: Fix BOOT_DEVICE_MEMORY_MAPPED
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54302/comment/979df360_009fb124
PS1, Line 7: Fix BOOT_DEVICE_MEMORY_MAPPED
:
: Also non SPI x86 is memory mapped.
A follow up question would be:
What do you consider 'non SPI'? What sort of protocols or boot mediums are being considered? As Furquan mentioned, the intention of the change isn't clear in what the change is trying to achieve.
On some older boards there is LPC flash instead of SPI. Emulation qemu boards also don't have SPI emulated. To answer Furquans question: It looks like it is only used in arch/x86/postcar_loader.c to set up a WP MTRR for the ROM.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54302
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c21e87d3375220a50645e0bf8b56fd23983f0c0
Gerrit-Change-Number: 54302
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Wed, 02 Jun 2021 15:50:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment