[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8192: Do memory pll init before calibration

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44702 )

Change subject: soc/mediatek/mt8192: Do memory pll init before calibration
......................................................................

Patch Set 45:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44702/45/src/soc/mediatek/mt8192/dr... 
File src/soc/mediatek/mt8192/dramc_pi_main.c:

https://review.coreboot.org/c/coreboot/+/44702/45/src/soc/mediatek/mt8192/dr... 
PS45, Line 23: 0x3
Please turn this (and following magic numbers) into definition of names.

You can use the SET_BITFIELDS32 API, which will apparently include names for register fields, and then define values for them.