Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37324 )
Change subject: soc/amd/common: Access ACPIMMIO via proper symbols ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37324/13/src/soc/amd/common/block/i... File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/37324/13/src/soc/amd/common/block/i... PS13, Line 117: ACPIMMIO_WDT_BANK
These are not base addresses
How about _OFFSET?