Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35233 )
Change subject: intel/fsp2_0: Move temporary RAM to .bss with FSP_USES_CB_STACK
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1:
Subrata, can you take over this one and have the allocations match with the specs like Furguan suggests?
It causes hang inside FSP (during FSP-M init) in both CNL/ICL where earlier DACHE_BSP_STACK_SIZE was 0x20000 (~128KB)
Not surprised. Like Furquan commented, we probably still need some increase for DCACHE_BSP_STACK_SIZE but did not find what the correct value would be. Also it has not been documented if (the ill-named) StackBase has to be aligned to StackSize in UPD.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35233
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4cffcc73a89cb97ab7759dd373196ce9753a6307
Gerrit-Change-Number: 35233
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 03 Sep 2019 08:40:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment