Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46234 )
Change subject: mb/google/volteer: Drop GPIO_MEM_CONFIG macros
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
This would need update as well: https://review.coreboot.org/cgit/coreboot.git/tree/util/mainboard/google/vol...
https://review.coreboot.org/c/coreboot/+/46234/4/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/memory.c:
https://review.coreboot.org/c/coreboot/+/46234/4/src/mainboard/google/voltee...
PS4, Line 72: GPP_C12,
It would be good to have a comment here which will make it easier to associate which GPIO corresponds to which config bit.
GPP_C12, /* GPIO_MEM_CONFIG_0 */
GPP_C15, /* GPIO_MEM_CONFIG_1 */
...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46234
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c1ebfb39b2a56ca94a92941e8beed1acc28e655
Gerrit-Change-Number: 46234
Gerrit-PatchSet: 4
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 13 Oct 2020 17:52:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment