[coreboot-gerrit] [M] Change in coreboot[main]: Choose Correct FW splash screen at runtime

[Paul Menzel (Code Review)]

Attention is currently required from: Andrey Petrov, Ronak Kanabar, Shelley Chen, Subrata Banik.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79775?usp=email )

Change subject: Choose Correct FW splash screen at runtime
......................................................................

Patch Set 8:

(8 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/79775/comment/9c27c309_4e6fc6e2 :
PS8, Line 7: Choose Correct FW splash screen at runtime
It’d be great if you rephrased, as it seems ChromeOS specific?

https://review.coreboot.org/c/coreboot/+/79775/comment/9cfe3705_e5b28d7d :
PS8, Line 7: Choose Correct FW splash screen at runtime
correct

https://review.coreboot.org/c/coreboot/+/79775/comment/eef1d4a4_3ee2df28 :
PS8, Line 16: CB_
Does CB mean coreboot or Chromebook?

https://review.coreboot.org/c/coreboot/+/79775/comment/ae2c7de5_8810c265 :
PS8, Line 15:     CHROMEOS_FW_SPLASH_SCREEN
            :     CB_LOGO_PATH
            :     CB_PLUS_LOGO_PATH
Please mark it up as a list.

File src/include/bootsplash.h:

https://review.coreboot.org/c/coreboot/+/79775/comment/6ca7481c_9ce89c38 :
PS8, Line 19: Allow platform-specific BMP logo overrides via
            :  * HAVE_CUSTOM_BMP_LOGO config.
            :  * For example: Introduce configurable BMP logo for
            :  * customization on platforms like ChromeOS
Please use the fully allowed text width.

File src/vendorcode/google/chromeos/Kconfig:

https://review.coreboot.org/c/coreboot/+/79775/comment/ce2df748_da7c2c1c :
PS8, Line 83: Firmware
firmware

https://review.coreboot.org/c/coreboot/+/79775/comment/72205482_6efdaaa4 :
PS8, Line 95: Logo
logo

https://review.coreboot.org/c/coreboot/+/79775/comment/c120e75b_b7392d83 :
PS8, Line 100: Logo
logo