Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40620 )
Change subject: mb/lenovo/x200: Add support for ThinkLight ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/40620/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40620/1//COMMIT_MSG@11 PS1, Line 11: https://review.coreboot.org/c/coreboot/+/19644. Please use the commit hash and summary.
https://review.coreboot.org/c/coreboot/+/40620/1//COMMIT_MSG@16 PS1, Line 16: echo off >/proc/acpi/ibm/light Please indent with four spaces (as in Markdown).
https://review.coreboot.org/c/coreboot/+/40620/1//COMMIT_MSG@18 PS1, Line 18: I have tested it on an X200 and it seems to work fine. With what Linux kernel?
https://review.coreboot.org/c/coreboot/+/40620/1/src/mainboard/lenovo/x200/a... File src/mainboard/lenovo/x200/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/40620/1/src/mainboard/lenovo/x200/a... PS1, Line 60: } I guess some refactoring in common/shared code with all the Lenovo ThinkPads would be nice.