29 Oct
2019
29 Oct
'19
8:38 p.m.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36250 )
Change subject: mainboard/google: Rework Hatch so that SPD in CBFS is optional ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36250/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/36250/2/src/mainboard/google/hatch/... PS2, Line 61: ROMSTAGE_SPD_CBFS
Wouldn't it be easier to add a Kconfig ROMSTAGE_SPD_SMBUS instead of ROMSTAGE_SPD_CBFS. […]
+1 to Kconfig
--
To view, visit https://review.coreboot.org/c/coreboot/+/36250
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1637d08cdd85bc8d7c3b6f2d6f386d0e0c6589b
Gerrit-Change-Number: 36250
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Daniel Kurtz djkurtz@google.com
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Shelley Chen shchen@google.com
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 30 Oct 2019 02:38:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment