Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34449 )
Change subject: soc/intel/common: Set controller state to active in GSPI init ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34449/4/src/soc/intel/common/block/... File src/soc/intel/common/block/gspi/gspi.c:
https://review.coreboot.org/c/coreboot/+/34449/4/src/soc/intel/common/block/... PS4, Line 25: #include <intelblocks/gspi.h> : #include <intelblocks/spi.h> : #include <intelblocks/lpss.h> nit: can we align order