Attention is currently required from: Furquan Shaikh, Mario Scheithauer, Werner Zeh.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52721 )
Change subject: mb/siemens/mc_apl{1,2,3,5,6}: Tune I2C frequency
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I think it's a little strange to set i2c speed twice, but the designware driver is built that way.
It's not really setting the i2c speed twice, the second one is telling the provided SCL hcnt/lcnt are ones to be used with the specified speed. If one should need to change the bus frequency during development, a different set of hcnt/lcnt need to be provided too.
AFAICS the .rise_time_ns approach is less hassle.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52721
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab634190bda5fa2a4fdf2ebaa1e45ac897d84deb
Gerrit-Change-Number: 52721
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Thu, 29 Apr 2021 08:52:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-MessageType: comment