build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29161 )
Change subject: src: Remove unneeded whitespace before and after parenthesis ......................................................................
Patch Set 2:
(147 comments)
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... File src/cpu/amd/family_10h-family_15h/fidvid.c:
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 173: if (nbPState){ space required before the open brace '{'
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 178: if (msr.hi & PS_EN_MASK) { suspect code indent for conditional statements (32, 32)
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 383: if (AMD_CpuFindCapability(node, 0, &offset)) { suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 415: for (j=0; (j<4) && (!isocEn); j++) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 415: for (j=0; (j<4) && (!isocEn); j++) { spaces required around that '<' (ctx:VxV)
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 498: if (cpuRev & (AMD_DA_Cx | AMD_RB_C3)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 503: if ((procPkg == AMD_PKGTYPE_G34) || (procPkg == AMD_PKGTYPE_C32)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 666: if ((((u32)0xffffffff) - initial_msr.lo) < corrected_timeout) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 675: || ((tsc_msr.hi == timeout.hi) && (tsc_msr.lo > timeout.lo)); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 676: } while ((pstate_msr.lo != target_pstate) && (! timedout)); space prohibited after that '!' (ctx:BxW)
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 685: } while (pstate_msr.lo != target_pstate ); space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 842: vid_max = (reg1fc & SINGLE_PLANE_NB_VID_MASK) >> SINGLE_PLANE_NB_VID_SHIFT; line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 843: fid_max = (reg1fc & SINGLE_PLANE_NB_FID_MASK) >> SINGLE_PLANE_NB_FID_SHIFT; line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 846: vid_max = vid_max - ((reg1fc & DUAL_PLANE_NB_VID_OFF_MASK) >> DUAL_PLANE_NB_VID_SHIFT); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 847: fid_max = fid_max + ((reg1fc & DUAL_PLANE_NB_FID_OFF_MASK) >> DUAL_PLANE_NB_FID_SHIFT); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/fi... PS2, Line 951: if ( (msr.hi & PS_IDD_VALUE_MASK) space prohibited after that open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/po... File src/cpu/amd/family_10h-family_15h/powernow_acpi.c:
https://review.coreboot.org/#/c/29161/2/src/cpu/amd/family_10h-family_15h/po... PS2, Line 229: * Based on the CPU socket type, cmp_cap and pwr_lmt, get the power limit. line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/cpu/via/nano/nano_init.c File src/cpu/via/nano/nano_init.c:
https://review.coreboot.org/#/c/29161/2/src/cpu/via/nano/nano_init.c@120 PS2, Line 120: u8 stepping = (cpuid_eax(0x1)) &0xf; need consistent spacing around '&' (ctx:WxV)
https://review.coreboot.org/#/c/29161/2/src/cpu/via/nano/nano_init.c@125 PS2, Line 125: msr.lo |= ((1 << 25) | (1 << 26) | (1 << 31)); /* C1e, C2e, C3e */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/db-ft3b-lc/BiosCal... File src/mainboard/amd/db-ft3b-lc/BiosCallOuts.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/db-ft3b-lc/BiosCal... PS2, Line 145: FchParams->Imc.ImcEnableOverWrite = 1; /* 2 disable IMC, 1 enable IMC, 0 following hw strap setting */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/lamar/BiosCallOuts... File src/mainboard/amd/lamar/BiosCallOuts.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/lamar/BiosCallOuts... PS2, Line 162: FchParams->Imc.ImcEnableOverWrite = 1; /* 2 disable IMC, 1 enable IMC, 0 following hw strap setting */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/olivehill/BiosCall... File src/mainboard/amd/olivehill/BiosCallOuts.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/olivehill/BiosCall... PS2, Line 114: FchParams->Imc.ImcEnableOverWrite = 1; /* 2 disable IMC, 1 enable IMC, 0 following hw strap setting */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/olivehillplus/Bios... File src/mainboard/amd/olivehillplus/BiosCallOuts.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/olivehillplus/Bios... PS2, Line 128: FchParams->Imc.ImcEnableOverWrite = 1; /* 2 disable IMC, 1 enable IMC, 0 following hw strap setting */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/parmer/BiosCallOut... File src/mainboard/amd/parmer/BiosCallOuts.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/parmer/BiosCallOut... PS2, Line 114: FchParams->Imc.ImcEnableOverWrite = 1; /* 2 disable IMC, 1 enable IMC, 0 following hw strap setting */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/serengeti_cheetah_... File src/mainboard/amd/serengeti_cheetah_fam10/acpi_tables.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/serengeti_cheetah_... PS2, Line 71: if(!(sysconf.pci1234[i] & 0x1)) continue; space required before the open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/serengeti_cheetah_... PS2, Line 71: if(!(sysconf.pci1234[i] & 0x1)) continue; trailing statements should be on next line
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/serengeti_cheetah_... PS2, Line 108: current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *) current, 0, 0, 2, 5); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/serengeti_cheetah_... PS2, Line 140: if((sysconf.pci1234[i] & 1) != 1) continue; space required before the open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/serengeti_cheetah_... PS2, Line 140: if((sysconf.pci1234[i] & 1) != 1) continue; trailing statements should be on next line
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/serengeti_cheetah_... File src/mainboard/amd/serengeti_cheetah_fam10/get_bus_conf.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/serengeti_cheetah_... PS2, Line 148: if(!(sysconf.pci1234[i] & 0x1)) continue; space required before the open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/serengeti_cheetah_... PS2, Line 148: if(!(sysconf.pci1234[i] & 0x1)) continue; trailing statements should be on next line
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/serengeti_cheetah_... File src/mainboard/amd/serengeti_cheetah_fam10/mptable.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/serengeti_cheetah_... PS2, Line 71: if(!(sysconf.pci1234[i] & 0x1)) continue; space required before the open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/serengeti_cheetah_... PS2, Line 71: if(!(sysconf.pci1234[i] & 0x1)) continue; trailing statements should be on next line
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/serengeti_cheetah_... PS2, Line 134: if(!(sysconf.pci1234[i] & 0x1)) continue; space required before the open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/serengeti_cheetah_... PS2, Line 134: if(!(sysconf.pci1234[i] & 0x1)) continue; trailing statements should be on next line
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/thatcher/BiosCallO... File src/mainboard/amd/thatcher/BiosCallOuts.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/thatcher/BiosCallO... PS2, Line 114: FchParams->Imc.ImcEnableOverWrite = 1; /* 2 disable IMC, 1 enable IMC, 0 following hw strap setting */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/torpedo/gpio.c File src/mainboard/amd/torpedo/gpio.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/amd/torpedo/gpio.c@94 PS2, Line 94: if (BoardType == 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/29161/2/src/mainboard/bap/ode_e20XX/BiosCall... File src/mainboard/bap/ode_e20XX/BiosCallOuts.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/bap/ode_e20XX/BiosCall... PS2, Line 117: FchParams->Imc.ImcEnableOverWrite = 1; /* 2 disable IMC, 1 enable IMC, 0 following hw strap setting */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/bap/ode_e21XX/BiosCall... File src/mainboard/bap/ode_e21XX/BiosCallOuts.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/bap/ode_e21XX/BiosCall... PS2, Line 130: FchParams->Imc.ImcEnableOverWrite = 1; /* 2 disable IMC, 1 enable IMC, 0 following hw strap setting */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/a68n_5200/Bios... File src/mainboard/biostar/a68n_5200/BiosCallOuts.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/a68n_5200/Bios... PS2, Line 114: FchParams->Imc.ImcEnableOverWrite = 1; /* 2 disable IMC, 1 enable IMC, 0 following hw strap setting */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... File src/mainboard/biostar/am1ml/romstage.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 75: it_sio_write (dev, 0x25, 0x80); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 76: it_sio_write (dev, 0x26, 0x07); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 77: it_sio_write (dev, 0x28, 0x81); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 78: it_sio_write (dev, 0x2c, 0x06); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 79: it_sio_write (dev, 0x72, 0x00); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 80: it_sio_write (dev, 0x73, 0x00); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 81: it_sio_write (dev, 0xb3, 0x01); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 82: it_sio_write (dev, 0xb8, 0x00); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 83: it_sio_write (dev, 0xc0, 0x00); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 84: it_sio_write (dev, 0xc3, 0x00); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 85: it_sio_write (dev, 0xc8, 0x00); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 86: it_sio_write (dev, 0xc9, 0x07); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 87: it_sio_write (dev, 0xcb, 0x01); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 88: it_sio_write (dev, 0xf0, 0x10); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 89: it_sio_write (dev, 0xf4, 0x27); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 90: it_sio_write (dev, 0xf8, 0x20); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/biostar/am1ml/romstage... PS2, Line 91: it_sio_write (dev, 0xf9, 0x01); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/gizmosphere/gizmo/OemC... File src/mainboard/gizmosphere/gizmo/OemCustomize.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/gizmosphere/gizmo/OemC... PS2, Line 126: HW_RXEN_SEED(ANY_SOCKET, ANY_CHANNEL, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED), line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/gizmosphere/gizmo2/Bio... File src/mainboard/gizmosphere/gizmo2/BiosCallOuts.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/gizmosphere/gizmo2/Bio... PS2, Line 114: FchParams->Imc.ImcEnableOverWrite = 1; /* 2 disable IMC, 1 enable IMC, 0 following hw strap setting */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/hp/pavilion_m6_1035dx/... File src/mainboard/hp/pavilion_m6_1035dx/BiosCallOuts.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/hp/pavilion_m6_1035dx/... PS2, Line 115: FchParams->Imc.ImcEnableOverWrite = 1; /* 2 disable IMC, 1 enable IMC, 0 following hw strap setting */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/lenovo/g505s/BiosCallO... File src/mainboard/lenovo/g505s/BiosCallOuts.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/lenovo/g505s/BiosCallO... PS2, Line 115: FchParams->Imc.ImcEnableOverWrite = 1; /* 2 disable IMC, 1 enable IMC, 0 following hw strap setting */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/lenovo/t60/smihandler.... File src/mainboard/lenovo/t60/smihandler.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/lenovo/t60/smihandler.... PS2, Line 52: printk(BIOS_DEBUG, "bar: %08X, level %02X\n", (unsigned int)bar, *(bar+LVTMA_BL_MOD_LEVEL)); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/lenovo/z61t/smihandler... File src/mainboard/lenovo/z61t/smihandler.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/lenovo/z61t/smihandler... PS2, Line 53: printk(BIOS_DEBUG, "bar: %08X, level %02X\n", (unsigned int)bar, line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/lippert/frontrunner-af... File src/mainboard/lippert/frontrunner-af/mainboard.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/lippert/frontrunner-af... PS2, Line 68: FCH_IOMUX(50) = 2; // GPIO50: FCH_ARST#_GATE resets stuck PCIe devices line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/lippert/frontrunner-af... PS2, Line 69: FCH_GPIO (50) = 0xC0; // = output set to 1 as it's never needed space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/lippert/frontrunner-af... PS2, Line 72: FCH_GPIO (56) = 0x28; // = inputs, disable int. pull-ups space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/lippert/frontrunner-af... PS2, Line 74: FCH_GPIO (57) = 0x28; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/lippert/frontrunner-af... PS2, Line 76: FCH_GPIO (58) = 0x28; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/lippert/frontrunner-af... PS2, Line 77: FCH_IOMUX(96) = 1; // "Gpio96": GEVENT0# signal on X2 connector (int. PU) line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/lippert/frontrunner-af... PS2, Line 78: FCH_IOMUX(52) = 1; // GPIO52,61,62,187-192 free to use on X2 connector line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/lippert/toucan-af/main... File src/mainboard/lippert/toucan-af/mainboard.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/lippert/toucan-af/main... PS2, Line 36: FCH_IOMUX(50) = 2; // GPIO50: FCH_ARST#_GATE resets stuck PCIe devices line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/lippert/toucan-af/main... PS2, Line 37: FCH_GPIO (50) = 0xC0; // = output set to 1 as it's never needed space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/lippert/toucan-af/main... PS2, Line 41: FCH_GPIO (56) = 0x28; // = inputs, disable int. pull-ups space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/lippert/toucan-af/main... PS2, Line 43: FCH_GPIO (57) = 0x28; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/lippert/toucan-af/main... PS2, Line 45: FCH_GPIO (58) = 0x28; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/msi/ms9652_fam10/get_b... File src/mainboard/msi/ms9652_fam10/get_bus_conf.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/msi/ms9652_fam10/get_b... PS2, Line 104: dev = dev_find_slot(m->bus_mcp55[0], PCI_DEVFN(sysconf.sbdn + 0x0a + i - 2, 0)); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/msi/ms9652_fam10/get_b... PS2, Line 109: printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:%02x.0, using defaults\n", m->bus_mcp55[0], sysconf.sbdn + 0x0a + i - 2); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/pcengines/apu1/OemCust... File src/mainboard/pcengines/apu1/OemCustomize.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/pcengines/apu1/OemCust... PS2, Line 111: HW_RXEN_SEED(ANY_SOCKET, ANY_CHANNEL, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED, RXSEED), line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/pcengines/apu2/mainboa... File src/mainboard/pcengines/apu2/mainboard.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/pcengines/apu2/mainboa... PS2, Line 170: pm_write16 (PM_RTC_CONTROL, pm_read16(PM_RTC_CONTROL) | (1 << 11)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/pcengines/apu2/mainboa... PS2, Line 175: pm_write16 (PM_S_STATE_CONTROL, pm_read16(PM_S_STATE_CONTROL) | (1 << 14)); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/pcengines/apu2/mainboa... PS2, Line 175: pm_write16 (PM_S_STATE_CONTROL, pm_read16(PM_S_STATE_CONTROL) | (1 << 14)); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/29161/2/src/mainboard/siemens/mc_tcu3/ptn346... File src/mainboard/siemens/mc_tcu3/ptn3460.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/siemens/mc_tcu3/ptn346... PS2, Line 56: if (hwilib_get_field(PF_Color_Depth,&color_depth, 1) != 1) { space required after that ',' (ctx:VxO)
https://review.coreboot.org/#/c/29161/2/src/mainboard/siemens/mc_tcu3/ptn346... PS2, Line 56: if (hwilib_get_field(PF_Color_Depth,&color_depth, 1) != 1) { space required before that '&' (ctx:OxV)
https://review.coreboot.org/#/c/29161/2/src/mainboard/supermicro/h8dmr_fam10... File src/mainboard/supermicro/h8dmr_fam10/get_bus_conf.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/supermicro/h8dmr_fam10... PS2, Line 102: dev = dev_find_slot(m->bus_mcp55[0], PCI_DEVFN(sysconf.sbdn + 0x0a + i - 2, 0)); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/supermicro/h8dmr_fam10... PS2, Line 107: printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:%02x.0, using defaults\n", m->bus_mcp55[0], sysconf.sbdn + 0x0a + i - 2); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/supermicro/h8qme_fam10... File src/mainboard/supermicro/h8qme_fam10/get_bus_conf.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/supermicro/h8qme_fam10... PS2, Line 108: dev = dev_find_slot(m->bus_mcp55[0], PCI_DEVFN(sysconf.sbdn + 0x0a + i - 2, 0)); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/supermicro/h8qme_fam10... PS2, Line 113: printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:%02x.0, using defaults\n", m->bus_mcp55[0], sysconf.sbdn + 0x0a + i - 2); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/supermicro/h8qme_fam10... File src/mainboard/supermicro/h8qme_fam10/romstage.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/supermicro/h8qme_fam10... PS2, Line 115: RC03, DIMM4, DIMM6,0, 0, DIMM5, DIMM7, 0, 0, space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29161/2/src/mainboard/tyan/s2912_fam10/get_b... File src/mainboard/tyan/s2912_fam10/get_bus_conf.c:
https://review.coreboot.org/#/c/29161/2/src/mainboard/tyan/s2912_fam10/get_b... PS2, Line 101: dev = dev_find_slot(m->bus_mcp55[0], PCI_DEVFN(sysconf.sbdn + 0x0a + i - 2, 0)); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/mainboard/tyan/s2912_fam10/get_b... PS2, Line 106: printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:%02x.0, using defaults\n", m->bus_mcp55[0], sysconf.sbdn + 0x0a + i - 2); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/northbridge/amd/agesa/family12/d... File src/northbridge/amd/agesa/family12/dimmSpd.c:
https://review.coreboot.org/#/c/29161/2/src/northbridge/amd/agesa/family12/d... PS2, Line 58: ) please, no spaces at the start of a line
https://review.coreboot.org/#/c/29161/2/src/northbridge/amd/amdmct/mct/mct_d... File src/northbridge/amd/amdmct/mct/mct_d.c:
https://review.coreboot.org/#/c/29161/2/src/northbridge/amd/amdmct/mct/mct_d... PS2, Line 1740: u8 ChipSel, Rows, Cols, Ranks,Banks, DevWidth; space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29161/2/src/northbridge/amd/pi/00730F01/dimm... File src/northbridge/amd/pi/00730F01/dimmSpd.c:
https://review.coreboot.org/#/c/29161/2/src/northbridge/amd/pi/00730F01/dimm... PS2, Line 37: if (info->SocketId >= DIMENSION(config->spdAddrLookup )) space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/29161/2/src/northbridge/amd/pi/00730F01/dimm... PS2, Line 39: if (info->MemChannelId >= DIMENSION(config->spdAddrLookup[0] )) space prohibited before that close parenthesis ')'
https://review.coreboot.org/#/c/29161/2/src/northbridge/intel/e7505/debug.c File src/northbridge/intel/e7505/debug.c:
https://review.coreboot.org/#/c/29161/2/src/northbridge/intel/e7505/debug.c@... PS2, Line 151: if (spd_read_byte(device, 0) < 0) continue; trailing statements should be on next line
https://review.coreboot.org/#/c/29161/2/src/northbridge/intel/fsp_rangeley/n... File src/northbridge/intel/fsp_rangeley/northbridge.c:
https://review.coreboot.org/#/c/29161/2/src/northbridge/intel/fsp_rangeley/n... PS2, Line 134: ram_resource(dev, index++, 0x100000000 >> 10, (bmbound_hi - 0x100000000) >> 10); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c File src/soc/broadcom/cygnus/ddr_init.c:
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@7... PS2, Line 74: reg32_write((volatile uint32_t *)DDR_PHY_CONTROL_REGS_STATIC_PAD_CTL, (readvalue & ~(1 << DDR_PHY_CONTROL_REGS_STATIC_PAD_CTL__RX_MODE_R))); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@7... PS2, Line 78: reg32_write((volatile uint32_t *)DDR_PHY_CONTROL_REGS_ZQ_CAL, (readvalue & ~(1 << DDR_PHY_CONTROL_REGS_ZQ_CAL__ZQ_IDDQ))); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@8... PS2, Line 82: reg32_write((volatile uint32_t *)DDR_PHY_BYTE_LANE_0_IDLE_PAD_CONTROL, (readvalue & ~(1 << DDR_PHY_BYTE_LANE_0_IDLE_PAD_CONTROL__IDLE))); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@8... PS2, Line 85: reg32_write((volatile uint32_t *)DDR_PHY_BYTE_LANE_0_IDLE_PAD_CONTROL, (readvalue & 0xffff800f)); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@8... PS2, Line 88: reg32_write((volatile uint32_t *)DDR_PHY_BYTE_LANE_0_IDLE_PAD_CONTROL, (readvalue & ~(1 << DDR_PHY_BYTE_LANE_0_IDLE_PAD_CONTROL__IDDQ))); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@9... PS2, Line 92: reg32_write((volatile uint32_t *)DDR_PHY_BYTE_LANE_1_IDLE_PAD_CONTROL, (readvalue & ~(1 << DDR_PHY_BYTE_LANE_1_IDLE_PAD_CONTROL__IDLE))); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@9... PS2, Line 95: reg32_write((volatile uint32_t *)DDR_PHY_BYTE_LANE_1_IDLE_PAD_CONTROL, (readvalue & 0xffff800f)); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@9... PS2, Line 98: reg32_write((volatile uint32_t *)DDR_PHY_BYTE_LANE_1_IDLE_PAD_CONTROL, (readvalue & ~(1 << DDR_PHY_BYTE_LANE_1_IDLE_PAD_CONTROL__IDDQ))); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@1... PS2, Line 146: #define SET_OVR_STEP(v) (0x30000 | ((v) & 0x3F)) /* OVR_FORCE = OVR_EN = 1, OVR_STEP = v */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@4... PS2, Line 452: reg32_write((volatile uint32_t *)DDR_DENALI_CTL_43, (1 << 17) | (1 << 24) | (1 << 25)); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@4... PS2, Line 458: if (reg32_read((volatile uint32_t *)DDR_DENALI_CTL_89) & (1 << 18)) { line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@4... PS2, Line 458: if (reg32_read((volatile uint32_t *)DDR_DENALI_CTL_89) & (1 << 18)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@4... PS2, Line 464: if (j == 0 && (reg32_read((volatile uint32_t *)DDR_DENALI_CTL_89) & (1 << 18)) == 0) { line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@9... PS2, Line 968: if ((((uint32_t)reg >= DDR_PHY_WORD_LANE_0_VDL_OVRIDE_BYTE_RD_EN) && ((uint32_t)reg <= (DDR_PHY_WORD_LANE_0_VDL_OVRIDE_BYTE_RD_EN + 0x114))) line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@9... PS2, Line 986: if (CONFIG_SHMOO_REUSE_MEMTEST_LENGTH > 0) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@1... PS2, Line 1121: for (i = 0; i < 1000; i++); please, no spaces at the start of a line
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@1... PS2, Line 1121: for (i = 0; i < 1000; i++); trailing statements should be on next line
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/ddr_init.c@1... PS2, Line 1380: if (val != 0) { suspect code indent for conditional statements (16, 12)
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/phy_reg_acce... File src/soc/broadcom/cygnus/phy_reg_access.c:
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/phy_reg_acce... PS2, Line 20: data = (* (volatile uint32 *) (((uint32)GLOBAL_REG_RBUS_START) | (address))); please, no spaces at the start of a line
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/phy_reg_acce... PS2, Line 27: ((* (volatile uint32 *) (((uint32)GLOBAL_REG_RBUS_START) | (address))) = data); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/broadcom/cygnus/phy_reg_acce... PS2, Line 27: ((* (volatile uint32 *) (((uint32)GLOBAL_REG_RBUS_START) | (address))) = data); please, no spaces at the start of a line
https://review.coreboot.org/#/c/29161/2/src/soc/intel/baytrail/perf_power.c File src/soc/intel/baytrail/perf_power.c:
https://review.coreboot.org/#/c/29161/2/src/soc/intel/baytrail/perf_power.c@... PS2, Line 224: E(CCU, 0x1c, MASK_VAL(1, 0, 0x0)), //vlv.ccu.clkgate_en_1.lps_free_clkgate_en line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/soc/intel/fsp_baytrail/fsp/chips... File src/soc/intel/fsp_baytrail/fsp/chipset_fsp_util.c:
https://review.coreboot.org/#/c/29161/2/src/soc/intel/fsp_baytrail/fsp/chips... PS2, Line 325: printk(BIOS_WARNING,"Rebooting..\n"); space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/29161/2/src/soc/intel/fsp_baytrail/northclus... File src/soc/intel/fsp_baytrail/northcluster.c:
https://review.coreboot.org/#/c/29161/2/src/soc/intel/fsp_baytrail/northclus... PS2, Line 161: ram_resource(dev, index++, 0x100000000 >> 10, highmem_size >> 10); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/agesa/hudson/ear... File src/southbridge/amd/agesa/hudson/early_setup.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/agesa/hudson/ear... PS2, Line 99: outb((dword >>(8 * i)) & 0xff, BIOSRAM_DATA); need consistent spacing around '>>' (ctx:WxV)
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/amd8111/acpi.c File src/southbridge/amd/amd8111/acpi.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/amd8111/acpi.c@1... PS2, Line 172: outl(((on<<1)+0x10) ,(pm10_bar + 0x10)); space prohibited before that ',' (ctx:WxV)
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/amd8111/acpi.c@1... PS2, Line 172: outl(((on<<1)+0x10) ,(pm10_bar + 0x10)); space required after that ',' (ctx:WxV)
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/amd8132/bridge.c File src/southbridge/amd/amd8132/bridge.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/amd8132/bridge.c... PS2, Line 388: if ((chip_rev == 0x11) ||(chip_rev == 0x12)) { spaces required around that '||' (ctx:WxV)
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/cimx/sb800/fan.c File src/southbridge/amd/cimx/sb800/fan.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/cimx/sb800/fan.c... PS2, Line 234: sb_config.Pecstruct.MSGFun89zone0MSGREG2 = (sb_chip->imc_tempin0_at & 0xff); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/cimx/sb800/fan.c... PS2, Line 238: sb_config.Pecstruct.MSGFun89zone0MSGREG6 = (sb_chip->imc_tempin0_ct & 0xff); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/cimx/sb800/fan.c... PS2, Line 252: sb_config.Pecstruct.MSGFun89zone1MSGREG2 = (sb_chip->imc_tempin1_at & 0xff); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/cimx/sb800/fan.c... PS2, Line 256: sb_config.Pecstruct.MSGFun89zone1MSGREG6 = (sb_chip->imc_tempin1_ct & 0xff); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/cimx/sb800/fan.c... PS2, Line 270: sb_config.Pecstruct.MSGFun89zone2MSGREG2 = (sb_chip->imc_tempin2_at & 0xff); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/cimx/sb800/fan.c... PS2, Line 274: sb_config.Pecstruct.MSGFun89zone2MSGREG6 = (sb_chip->imc_tempin2_ct & 0xff); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/cimx/sb800/fan.c... PS2, Line 288: sb_config.Pecstruct.MSGFun89zone3MSGREG2 = (sb_chip->imc_tempin3_at & 0xff); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/cimx/sb800/fan.c... PS2, Line 292: sb_config.Pecstruct.MSGFun89zone3MSGREG6 = (sb_chip->imc_tempin3_ct & 0xff); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/pi/hudson/early_... File src/southbridge/amd/pi/hudson/early_setup.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/pi/hudson/early_... PS2, Line 238: outb((dword >>(8 * i)) & 0xff, BIOSRAM_DATA); need consistent spacing around '>>' (ctx:WxV)
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/rs780/gfx.c File src/southbridge/amd/rs780/gfx.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/rs780/gfx.c@250 PS2, Line 250: if (Attribute & MMIO_ATTRIB_NP_ONLY && pMMIO[k].Attribute == 0) { line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/rs780/gfx.c@250 PS2, Line 250: if (Attribute & MMIO_ATTRIB_NP_ONLY && pMMIO[k].Attribute == 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/sb700/early_setu... File src/southbridge/amd/sb700/early_setup.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/sb700/early_setu... PS2, Line 819: outb((dword >>(8 * i)) & 0xff, BIOSRAM_DATA); need consistent spacing around '>>' (ctx:WxV)
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/sb700/ramtop.c File src/southbridge/amd/sb700/ramtop.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/sb700/ramtop.c@3... PS2, Line 35: outb((dword >>(8 * i)) & 0xff, BIOSRAM_DATA); need consistent spacing around '>>' (ctx:WxV)
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/sb700/sata.c File src/southbridge/amd/sb700/sata.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/sb700/sata.c@473 PS2, Line 473: (i % 2) ? "Slave" : "Master", i); line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/sb800/early_setu... File src/southbridge/amd/sb800/early_setup.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/sb800/early_setu... PS2, Line 636: outb((dword >>(8 * i)) & 0xff, BIOSRAM_DATA); need consistent spacing around '>>' (ctx:WxV)
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/sr5650/pcie.c File src/southbridge/amd/sr5650/pcie.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/amd/sr5650/pcie.c@80... PS2, Line 809: if (!((pci_read_config32(dev, 0x6C) >> 6) & 0x01)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/29161/2/src/southbridge/intel/bd82x6x/early_... File src/southbridge/intel/bd82x6x/early_usb.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/intel/bd82x6x/early_... PS2, Line 38: pci_write_config8(PCI_DEV(0, 0x1f, 0), 0x44 /* ACPI_CNTL */, 0x80); /* Enable ACPI BAR */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/southbridge/intel/fsp_bd82x6x/ea... File src/southbridge/intel/fsp_bd82x6x/early_init.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/intel/fsp_bd82x6x/ea... PS2, Line 145: pci_write_config8(PCI_DEV(0, 0x1f, 0), 0x44 /* ACPI_CNTL */, 0x80); /* Enable ACPI BAR */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/southbridge/intel/fsp_i89xx/earl... File src/southbridge/intel/fsp_i89xx/early_init.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/intel/fsp_i89xx/earl... PS2, Line 32: pci_write_config8(PCI_DEV(0, 0x1f, 0), 0x44 /* ACPI_CNTL */, 0x80); /* Enable ACPI BAR */ line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/southbridge/nvidia/ck804/early_s... File src/southbridge/nvidia/ck804/early_setup.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/nvidia/ck804/early_s... PS2, Line 258: RES_PCI_IO, PCI_ADDR(0, CK804_DEVN_BASE + 1, 0, 0xe4), ~(1 << 23), (1 << 23), line over 80 characters
https://review.coreboot.org/#/c/29161/2/src/southbridge/ricoh/rl5c476/rl5c47... File src/southbridge/ricoh/rl5c476/rl5c476.c:
https://review.coreboot.org/#/c/29161/2/src/southbridge/ricoh/rl5c476/rl5c47... PS2, Line 169: if (enable_cf_boot && (PCI_FUNC(dev->path.pci.devfn) == 1)){ space required before the open brace '{'
https://review.coreboot.org/#/c/29161/2/src/southbridge/ricoh/rl5c476/rl5c47... PS2, Line 184: if (enable_cf_boot && (PCI_FUNC(dev->path.pci.devfn) == 1)){ space required before the open brace '{'
https://review.coreboot.org/#/c/29161/2/src/southbridge/ricoh/rl5c476/rl5c47... PS2, Line 186: if (!(resource->flags & IORESOURCE_STORED)){ space required before the open brace '{'