[coreboot-gerrit] Change in coreboot[master]: Change all assert(0) to BUG()

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44047 )

Change subject: Change all assert(0) to BUG()
......................................................................

Change all assert(0) to BUG()

I would like to make assertions evaluate at compile time where possible,
but sometimes people used a literal assert(0) to force an assertion in a
certain code path. We already have BUG() for that so let's just replace
those instances with that.

Signed-off-by: Julius Werner 
Change-Id: I674e5f8ec7f5fe8b92b1c7c95d9f9202d422ce32
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44047
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Aaron Durbin 
Reviewed-by: Angel Pons 
---
M src/device/device_const.c
M src/soc/amd/common/block/gpio_banks/gpio.c
M src/soc/amd/picasso/reset.c
M src/soc/intel/common/block/gpio/gpio.c
M src/soc/mediatek/mt8183/mt6358.c
M src/southbridge/amd/pi/hudson/early_setup.c
6 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Aaron Durbin: Looks good to me, approved
  Furquan Shaikh: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/device/device_const.c b/src/device/device_const.c
index 79f025d..2dc583c 100644
--- a/src/device/device_const.c
+++ b/src/device/device_const.c
@@ -184,7 +184,7 @@
    DEVTREE_CONST struct device *child;

if (!parent) {
-		assert(0);
+		BUG();
    	/* Return NULL in case asserts are considered non-fatal. */
    	return NULL;
    }
@@ -282,7 +282,7 @@
    						pci_devfn_t devfn)
 {
    if (!bridge || (bridge->path.type != DEVICE_PATH_PCI)) {
-		assert(0);
+		BUG();
    	/* Return NULL in case asserts are non-fatal. */
    	return NULL;
    }
diff --git a/src/soc/amd/common/block/gpio_banks/gpio.c b/src/soc/amd/common/block/gpio_banks/gpio.c
index b9646b9..4f1b842 100644
--- a/src/soc/amd/common/block/gpio_banks/gpio.c
+++ b/src/soc/amd/common/block/gpio_banks/gpio.c
@@ -28,7 +28,7 @@

if (!is_gpio_event_level_triggered(flags)) {
    	printk(BIOS_ERR, "ERROR: %s - Only level trigger allowed for SMI!\n", __func__);
-		assert(0);
+		BUG();
    	return;
    }

diff --git a/src/soc/amd/picasso/reset.c b/src/soc/amd/picasso/reset.c
index b6aeb1f..902538ff 100644
--- a/src/soc/amd/picasso/reset.c
+++ b/src/soc/amd/picasso/reset.c
@@ -49,6 +49,6 @@
 {
    printk(BIOS_ERR, "Error: unexpected call to %s(0x%08x).  Doing cold reset.\n",
    		__func__, status);
-	assert(0);
+	BUG();
    do_cold_reset();
 }
diff --git a/src/soc/intel/common/block/gpio/gpio.c b/src/soc/intel/common/block/gpio/gpio.c
index ee91aa6..d6958b1 100644
--- a/src/soc/intel/common/block/gpio/gpio.c
+++ b/src/soc/intel/common/block/gpio/gpio.c
@@ -78,7 +78,7 @@
    }
    printk(BIOS_ERR, "%s: pad %d is not found in community %s!\n",
    		__func__, relative_pad, comm->name);
-	assert(0);
+	BUG();

return i;
 }
diff --git a/src/soc/mediatek/mt8183/mt6358.c b/src/soc/mediatek/mt8183/mt6358.c
index 7b4febc..6e6e43a 100644
--- a/src/soc/mediatek/mt8183/mt6358.c
+++ b/src/soc/mediatek/mt8183/mt6358.c
@@ -831,7 +831,7 @@
    	break;

default:
-		assert(0);
+		BUG();
    	return;
    };

diff --git a/src/southbridge/amd/pi/hudson/early_setup.c b/src/southbridge/amd/pi/hudson/early_setup.c
index 14bb5e2..f43dbb9 100644
--- a/src/southbridge/amd/pi/hudson/early_setup.c
+++ b/src/southbridge/amd/pi/hudson/early_setup.c
@@ -187,7 +187,7 @@
    		pci_write_config32(dev, LPC_WIDEIO2_GENERIC_PORT, tmp);
    		enable_wideio(2, size);
    	} else {	/* All WIDEIO locations used*/
-			assert(0);
+			BUG();
    	}
    }
 }