Attention is currently required from: Felix Singer, Timofey Komarov, Nico Huber, Maciej Pijanowski, Michał Żygowski, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Krystian Hebel, Marcello Sylvester Bauer.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50194 )
Change subject: util/liveiso: Add NixOS configs for bootable live systems
......................................................................
Patch Set 30: Code-Review+1
(2 comments)
Patchset:
PS30:
I am not familiar with NixOS configs, so I just did a rough plausibility check on these.
File util/liveiso/common.nix:
https://review.coreboot.org/c/coreboot/+/50194/comment/0d2a3ee6_1c5b986b
PS30, Line 3: # TODO
: # - Use programs.flashrom.enable (#128205) and add `user` to `flashrom` group.
: # Will be useable from the next NixOS release.
: # - Generate customized bootloader configs; FILO is WIP
: # - Add coreboot toolchain
:
I would move that to description.md
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50194
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c
Gerrit-Change-Number: 50194
Gerrit-PatchSet: 30
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Marcello Sylvester Bauer
sylv@sylv.io
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Timofey Komarov
happycorsair@yandex.ru
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Timofey Komarov
happycorsair@yandex.ru
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Maciej Pijanowski
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Marcello Sylvester Bauer
sylv@sylv.io
Gerrit-Comment-Date: Tue, 17 Aug 2021 19:40:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment