3 Jun
2019
3 Jun
'19
11:04 a.m.
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33149 )
Change subject: mb/apple/macbookair4_2: Fix DRAM_RESET_GATE_GPIO ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
Did you test if this changes suspend/resume behaviour/stability?
I didn't, because I don't have MBA 4,2. But I can test DRAM_RESET_GATE_GPIO=60 vs DRAM_RESET_GATE_GPIO=28 on MBA 5,2 and tell you results. Their design is similar, like T420 vs T430.
--
To view, visit https://review.coreboot.org/c/coreboot/+/33149
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55be1ed178c818a17766e22cb2fd010412b8fe02
Gerrit-Change-Number: 33149
Gerrit-PatchSet: 1
Gerrit-Owner: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 03 Jun 2019 11:04:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment