Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33149
Change subject: mb/apple/macbookair4_2: Fix DRAM_RESET_GATE_GPIO ......................................................................
mb/apple/macbookair4_2: Fix DRAM_RESET_GATE_GPIO
It's GPIO28 according to schematics.
Change-Id: I55be1ed178c818a17766e22cb2fd010412b8fe02 Signed-off-by: Evgeny Zinoviev me@ch1p.io --- M src/mainboard/apple/macbookair4_2/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/33149/1
diff --git a/src/mainboard/apple/macbookair4_2/Kconfig b/src/mainboard/apple/macbookair4_2/Kconfig index 4b2ee8f..df8ecfd 100644 --- a/src/mainboard/apple/macbookair4_2/Kconfig +++ b/src/mainboard/apple/macbookair4_2/Kconfig @@ -33,7 +33,7 @@
config DRAM_RESET_GATE_GPIO int - default 60 + default 28
config MAX_CPUS int
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33149 )
Change subject: mb/apple/macbookair4_2: Fix DRAM_RESET_GATE_GPIO ......................................................................
Patch Set 1: Code-Review+1
Did you test if this changes suspend/resume behaviour/stability?
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33149 )
Change subject: mb/apple/macbookair4_2: Fix DRAM_RESET_GATE_GPIO ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
Did you test if this changes suspend/resume behaviour/stability?
I didn't, because I don't have MBA 4,2. But I can test DRAM_RESET_GATE_GPIO=60 vs DRAM_RESET_GATE_GPIO=28 on MBA 5,2 and tell you results. Their design is similar, like T420 vs T430.
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33149 )
Change subject: mb/apple/macbookair4_2: Fix DRAM_RESET_GATE_GPIO ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
Did you test if this changes suspend/resume behaviour/stability?
Tested, suspend/resume works fine with 60 and with 28, actually.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33149 )
Change subject: mb/apple/macbookair4_2: Fix DRAM_RESET_GATE_GPIO ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33149 )
Change subject: mb/apple/macbookair4_2: Fix DRAM_RESET_GATE_GPIO ......................................................................
mb/apple/macbookair4_2: Fix DRAM_RESET_GATE_GPIO
It's GPIO28 according to schematics.
Change-Id: I55be1ed178c818a17766e22cb2fd010412b8fe02 Signed-off-by: Evgeny Zinoviev me@ch1p.io Reviewed-on: https://review.coreboot.org/c/coreboot/+/33149 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/apple/macbookair4_2/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Felix Held: Looks good to me, approved
diff --git a/src/mainboard/apple/macbookair4_2/Kconfig b/src/mainboard/apple/macbookair4_2/Kconfig index 4b2ee8f..df8ecfd 100644 --- a/src/mainboard/apple/macbookair4_2/Kconfig +++ b/src/mainboard/apple/macbookair4_2/Kconfig @@ -33,7 +33,7 @@
config DRAM_RESET_GATE_GPIO int - default 60 + default 28
config MAX_CPUS int
-
Evgeny Zinoviev (Code Review) -
Felix Held (Code Review)
-
Nico Huber (Code Review)