Nina-CM Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46402 )
Change subject: soc/mediatek/mt8192: devapc: add basic devapc drivers ......................................................................
Patch Set 47:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46402/46/src/soc/mediatek/mt8192/Ma... File src/soc/mediatek/mt8192/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46402/46/src/soc/mediatek/mt8192/Ma... PS46, Line 44: ramstage-y += devapc.c
Put it before dpm. […]
Done
https://review.coreboot.org/c/coreboot/+/46402/46/src/soc/mediatek/mt8192/de... File src/soc/mediatek/mt8192/devapc.c:
https://review.coreboot.org/c/coreboot/+/46402/46/src/soc/mediatek/mt8192/de... PS46, Line 6: static unsigned long devapc_ao_base;
I think relying on this static variable is not a good idea. […]
Done
https://review.coreboot.org/c/coreboot/+/46402/46/src/soc/mediatek/mt8192/de... PS46, Line 16:
Remove extra indents
Done
https://review.coreboot.org/c/coreboot/+/46402/46/src/soc/mediatek/mt8192/de... PS46, Line 43: devapc_ao_base
this can be a local variable.
Done