Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45811 )
Change subject: mb/google/kukui: Support SKU from camera EEPROM ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45811/5/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/45811/5/src/mainboard/google/kukui/... PS5, Line 14: select CHROMEOS_CAMERA let's keep Kconfig.name simple. Instead you should put add a
select CHROMEOS_CAMERA if BOARD_GOOGLE_KODAMA
in Kconfig BOARD_SPECIFIC_OPTIONS section.
In fact, since we're in public drivers now, I think it's totally fine to always include the driver:
select CHROMEOS_CAMERA
then you don't have to 'return 0' by checking CONFIG_CHROMEOS_CAMERA.