Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39342 )
Change subject: vboot: remove VBOOT_NO_BOARD_SUPPORT Kconfig
......................................................................
Patch Set 1:
the existing Kconfig description implies that it should be removed.
I think the "replaced by interfaces" bit was specific to write-protect (I guess the idea was that we'd have a generic concept for reading the #WP pin in drivers/spi at some point, but now we ended up getting rid of it completely instead, which I think is also fine). It doesn't mean that we would just make the functions weak instead... if we had wanted to do that, we could have done it back then already (see original discussion in CB:22102).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39342
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccef100fac1d71625039990373e40b29d52a0167
Gerrit-Change-Number: 39342
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 07 Mar 2020 06:02:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment