Attention is currently required from: Daniel Maslowski, Daniel Maslowski, Martin L Roth, ron minnich.
Ayan Agrawal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77410?usp=email )
Change subject: qemu-riscv: Improve Documentation
......................................................................
Patch Set 6:
(2 comments)
This change is ready for review.
File src/arch/riscv/romstage.S:
https://review.coreboot.org/c/coreboot/+/77410/comment/e668764a_06de824d :
PS3, Line 39:
Unrelated to the documentation. […]
Done
File src/mainboard/emulation/qemu-riscv/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/77410/comment/88e0bb6d_f20e502d :
PS3, Line 35:
This removal is unrelated to the documentation - Move it to a cleanup patch?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77410?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6dbddb6d8801c456196142c3c7d0a2cbf2ed0fb7
Gerrit-Change-Number: 77410
Gerrit-PatchSet: 6
Gerrit-Owner: Ayan Agrawal
ayanagr03@gmail.com
Gerrit-Reviewer: Daniel Maslowski
cyrevolt@googlemail.com
Gerrit-Reviewer: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Daniel Maslowski
info@orangecms.org
Gerrit-Attention: Daniel Maslowski
cyrevolt@googlemail.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Wed, 15 Nov 2023 14:55:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Gerrit-MessageType: comment