Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45635 )
Change subject: vendorcode/google: add CHROMEOS_DRAM_PART_NUMBER_IN_CBI Kconfig option ......................................................................
Patch Set 19:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45635/18//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45635/18//COMMIT_MSG@16 PS18, Line 16: but will : change to defaulting to "y"
This is not really correct as mentioned on earlier patchset.
Done
https://review.coreboot.org/c/coreboot/+/45635/17/src/vendorcode/google/chro... File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/45635/17/src/vendorcode/google/chro... PS17, Line 107: y
If so, why would we not want to default to y, and just let any chromebooks that go against the nor […]
Thanks for the explanation, makes perfect sense.
https://review.coreboot.org/c/coreboot/+/45635/18/src/vendorcode/google/chro... File src/vendorcode/google/chromeos/dram_part_num_override.c:
https://review.coreboot.org/c/coreboot/+/45635/18/src/vendorcode/google/chro... PS18, Line 10:
I think we should have a check to ensure that we don't make a call to EC every time mainboard_get_dr […]
Done
https://review.coreboot.org/c/coreboot/+/45635/18/src/vendorcode/google/chro... PS18, Line 12: sizeof(part_num_store)) < 0) {
nit: this probably fits on the previous line?
Ack