[coreboot-gerrit] Change in coreboot[master]: drivers/uart: Override uart base address

[Marc Jones (Code Review)]

Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45405 )

Change subject: drivers/uart: Override uart base address
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45405/2/src/drivers/uart/uart8250io... 
File src/drivers/uart/uart8250io.c:

https://review.coreboot.org/c/coreboot/+/45405/2/src/drivers/uart/uart8250io... 
PS2, Line 78: static const unsigned int bases[] = { 0x3f8, 0x2f8, 0x3e8, 0x2e8 };
> Use any base address. […]

What address would you use that isn't listed? I think that bases[] is the only valid settings. It is structured this way so that menuconfig works. I'm trying to understand the use case for change this runtime and not build time. Also, this doesn't handle the early uart/serial init.

I don't think that a weak function boots the right way. I'd rather a CONFIG option that is more deterministic, but I don't know what the current coreboot policy is on this. It is hard to tell which function is being built, but I guess this is more obvious since it would need to be in the mainboard you are building.