Ting Shen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31123 )
Change subject: bootmem: add new memory type for BL31 ......................................................................
Patch Set 12:
(4 comments)
https://review.coreboot.org/#/c/31123/11/src/arch/arm64/include/arch/memlayo... File src/arch/arm64/include/arch/memlayout.h:
https://review.coreboot.org/#/c/31123/11/src/arch/arm64/include/arch/memlayo... PS11, Line 41: 1K
nit: Did you base this number on anything? The BL31 linker script aligns start and end of the ELF to […]
Done. It was copied from cavium/cn81xx/include/soc/memlayout.ld.
https://review.coreboot.org/#/c/31123/11/src/soc/nvidia/tegra210/soc.c File src/soc/nvidia/tegra210/soc.c:
https://review.coreboot.org/#/c/31123/11/src/soc/nvidia/tegra210/soc.c@41 PS11, Line 41: 0
nit: CARVEOUT_TZ
Done
https://review.coreboot.org/#/c/31123/11/src/soc/nvidia/tegra210/soc.c@44 PS11, Line 44: bootmem_add_range(begin * KiB * KiB, size * KiB * KiB, BM_MEM_BL31);
MiB
Done
https://review.coreboot.org/#/c/31123/11/src/soc/nvidia/tegra210/soc.c@53 PS11, Line 53: for (i = 1; i < CARVEOUT_NUM; i++) {
... […]
Done