[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: Read DRAM part number from CBI

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40836 )

Change subject: mb/google/dedede: Read DRAM part number from CBI
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/40836/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/romstage.c:

https://review.coreboot.org/c/coreboot/+/40836/2/src/mainboard/google/dedede... 
PS2, Line 42: strlen(part_num_store)
> And refer to [1], it is processed by strncpy and MIN(sizeof(dimm->module_part_number), module_part_n […]

I was wondering whether google_chromeec_cbi_get_dram_part_num puts in a NUL terminated string. It seems it is doing so.

Also sizeof is a compile-time expression whereas strlen needs to determine the size at run-time.

Anyways I am fine either ways.