Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32363 )
Change subject: pcengines/apu2: implement POSTCAR_STAGE ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/32363/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/32363/4//COMMIT_MSG@9 PS4, Line 9: was is
https://review.coreboot.org/c/coreboot/+/32363/4//COMMIT_MSG@11 PS4, Line 11: Please elaborate. Did post codes change? Any impact on the boot time?
https://review.coreboot.org/c/coreboot/+/32363/4//COMMIT_MSG@12 PS4, Line 12: since starting
https://review.coreboot.org/c/coreboot/+/32363/4/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/postcar.c:
https://review.coreboot.org/c/coreboot/+/32363/4/src/mainboard/pcengines/apu... PS4, Line 22: outb(0xEA, 0xCD6); : outb(0x1, 0xcd7); Please use consistent lower or upper case spelling. No idea what is more common in coreboot, I believe lowercase.