Attention is currently required from: Karthik Ramasubramanian, Nick Vaccaro, Subrata Banik.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85025?usp=email )
Change subject: soc/intel/cmn/pmc: Perform PM register init for CSE
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/85025/comment/a6a818c4_f49498fb?usp... :
PS1, Line 496: pmc_enable_pm1_control(pm1_cnt_value)
Acknowledged
i guess with line 492, we can safely assume that all SLP_TYPE offsets are cleared otherwise, we won't be landing inside this `if` loop. I'm avoiding steps to clear the slp_type and reading the pm1_cnt that i have introduced with my last patchset.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85025?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iae9c026da86fef4a3571e06b1bb20504c3d8c9be
Gerrit-Change-Number: 85025
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 11 Nov 2024 08:24:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com