[coreboot-gerrit] [S] Change in coreboot[master]: Revert "soc/intel/{tgl,adl}: Hook up D3ColdEnable UPD to D3COLD_SUPPORT"

[Michael Niewöhner (Code Review)]

Attention is currently required from: Felix Singer, Sean Rhodes, Tarun Tuli, Subrata Banik, Christian Walter, Maximilian Brune, Angel Pons, Martin Roth, Lean Sheng Tan.

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73902 )

Change subject: Revert "soc/intel/{tgl,adl}: Hook up D3ColdEnable UPD to D3COLD_SUPPORT"
......................................................................

Patch Set 4:

(2 comments)

Patchset:

PS4:
> Isn't the only problem with the patch the "don't" in the help text? Surely it's easier to just remove that.

No, check CB:73903 for the main reasons, please. I've also added references to the various problems now.
> For sure, there is a devicetree option but the point of this patch was to tie ACPI and FSP together to one Kconfig option

However, this created a conflict. It's not a good idea to have both devicetree option AND Kconfig for the same thing

File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/73902/comment/98226af7_28c1dc9e 
PS4, Line 325: 	params->D3HotEnable = !config->TcssD3HotDisable;
             : 	cpu_id = cpu_get_cpuid();
             : 	if (cpu_id == CPUID_TIGERLAKE_A0)
             : 		params->D3ColdEnable = 0;
             : 	else
             : 		params->D3ColdEnable = !config->TcssD3ColdDisable;
             : 
for reference: https://review.coreboot.org/c/coreboot/+/72800/4/src/soc/intel/tigerlake/fsp...