Roy Mingi Park has uploaded this change for review. ( https://review.coreboot.org/29007
Change subject: mb/google/poppy/variants/nocturne: Disable pull-down of GPP_E9/E10 ......................................................................
mb/google/poppy/variants/nocturne: Disable pull-down of GPP_E9/E10
While these pins were set to a pull-down 20KOhm, NPCX EC consumes ~2.1mW higher power. Becasue there was leakage current on both GPIO67 and GPIO70 from NPCX EC. With the external pull-up 10KOhm for USB_OC0#/USB2_OC1#, this wasn't enough to prevent leakage current.
Change-Id: I685d876461c263f07ca4c8f8046635cb7087279c Signed-off-by: Roy Mingi Park roy.mingi.park@intel.com --- M src/mainboard/google/poppy/variants/nocturne/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/29007/1
diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c index 8f87705..16ff982 100644 --- a/src/mainboard/google/poppy/variants/nocturne/gpio.c +++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c @@ -229,9 +229,9 @@ /* E8 : SATALED# ==> NC */ PAD_CFG_NC(GPP_E8), /* E9 : USB2_OCO# ==> USB_C0_OC_ODL */ - PAD_CFG_NF(GPP_E9, 20K_PD, DEEP, NF1), + PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), /* E10 : USB2_OC1# ==> USB_C1_OC_ODL */ - PAD_CFG_NF(GPP_E10, 20K_PD, DEEP, NF1), + PAD_CFG_NF(GPP_E10, NONE, DEEP, NF1), /* E11 : USB2_OC2# ==> TOUCHSCREEN_RESET_L */ PAD_CFG_TERM_GPO(GPP_E11, 0, 20K_PD, DEEP), /* E12 : USB2_OC3# ==> NC */