Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33447 )
Change subject: Documentation: Explain SimpleELF
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33447/1/Documentation/lib/payloads/selfboot....
File Documentation/lib/payloads/selfboot.md:
https://review.coreboot.org/#/c/33447/1/Documentation/lib/payloads/selfboot....
PS1, Line 23: argument.
I don't think this is true on x86, the coreboot table address is still hardcoded there.
True, but looks looks like a bug to me.
Is there any historic reason not to pass the argument?
https://review.coreboot.org/#/c/33447/2/Documentation/lib/payloads/selfboot....
File Documentation/lib/payloads/selfboot.md:
https://review.coreboot.org/#/c/33447/2/Documentation/lib/payloads/selfboot....
PS2, Line 3: static
statically
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33447
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia217af7d39505393ed9324fbe53b4ca7f3069e2e
Gerrit-Change-Number: 33447
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Ting Shen
phoenixshen@google.com
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 23 Jun 2019 11:27:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment